vm: Add a transaction execution function #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/3185_execute
branch
from
7c53d2c to
15623e0
Compare
moCello
force-pushed
the
mocello/3185_execute
branch
3 times, most recently
from
eaf0a6a to
87fd7a8
Compare
HDauven
previously approved these changes
Dec 16, 2024
There was a problem hiding this comment.
LGTM, very nice how we can get rid of the execute in test utils
It might be good to wait for a second opinion from @miloszm or @herr-seppia though
miloszm
requested changes
Dec 17, 2024
moCello
changed the title
moCello
changed the title
moCello
force-pushed
the
mocello/3185_execute
branch
from
87fd7a8 to
f957ca8
Compare
moCello
force-pushed
the
mocello/3185_execute
branch
from
f957ca8 to
8ebe6ed
Compare
HDauven
previously approved these changes
Dec 21, 2024
There was a problem hiding this comment.
LGTM!
Tested a binary based off of commit 8ebe6edc4c98a3cf654cba457034a02597e8cb19 against testnet. Works as expected and is backward compatible.
miloszm
previously approved these changes
Dec 21, 2024
moCello
dismissed stale reviews from miloszm and HDauven
The base branch was changed.
moCello
force-pushed
the
mocello/3185_execute
branch
from
8ebe6ed to
e59474d
Compare
HDauven
previously approved these changes
Dec 22, 2024
moCello
force-pushed
the
mocello/3185_execute
branch
from
9b98d54 to
e59474d
Compare
HDauven
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to move
executeto ourvmsome contract-deployment functionalities had to move as well:dusk_core::transfer::Transaction.deploy_chargedusk_core::transfer::data::Bytecode.verify_hashdusk_core::abi::gen_contract_idResolves #3185